Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the retry of the rpc client #26795

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Improve the retry of the rpc client #26795

merged 1 commit into from
Sep 6, 2023

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Sep 1, 2023

issue: #26793

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Sep 1, 2023
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 1, 2023
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Sep 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@SimFG Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Sep 1, 2023
@SimFG SimFG mentioned this pull request Sep 1, 2023
Merged
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG SimFG force-pushed the master branch 2 times, most recently from b482e78 to fa12868 Compare September 1, 2023 03:09
wayblink
wayblink approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@wayblink wayblink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one minor comment

internal/util/grpcclient/client.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Sep 1, 2023

/run-cpu-e2e

@SimFG SimFG force-pushed the master branch 2 times, most recently from 3b6e320 to 1923120 Compare September 2, 2023 15:01
@codecov
Copy link

codecov bot commented Sep 2, 2023 •
edited
Loading

Codecov Report

Merging #26795 (f162d65) into master (73f4347) will decrease coverage by 0.02%.
Report is 12 commits behind head on master.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26795      +/-   ##
==========================================
- Coverage   82.30%   82.28%   -0.02%     
==========================================
  Files         796      796              
  Lines      110538   110603      +65     
==========================================
+ Hits        90973    91008      +35     
- Misses      16437    16463      +26     
- Partials     3128     3132       +4
Files Changed Coverage Δ
internal/querycoordv2/server.go 79.09% <0.00%> (-0.19%) ⬇️
pkg/util/merr/utils.go 94.97% <60.00%> (+0.02%) ⬆️
internal/util/grpcclient/client.go 77.14% <81.25%> (+1.19%) ⬆️
internal/querycoordv2/meta/collection_manager.go 88.11% <100.00%> (+0.17%) ⬆️
internal/querycoordv2/meta/coordinator_broker.go 67.28% <100.00%> (ø)
internal/querynodev2/handlers.go 76.88% <100.00%> (ø)
internal/querynodev2/segments/result.go 75.00% <100.00%> (+0.08%) ⬆️
internal/rootcoord/root_coord.go 90.21% <100.00%> (ø)
pkg/util/merr/errors.go 93.75% <100.00%> (ø)
pkg/util/paramtable/grpc_param.go 80.15% <100.00%> (+1.50%) ⬆️
... and 1 more

... and 24 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 2, 2023
@mergify mergify bot removed the ci-passed label Sep 3, 2023
@SimFG
Copy link
Contributor Author

SimFG commented Sep 4, 2023

rerun ut

@mergify mergify bot added the ci-passed label Sep 4, 2023
@mergify mergify bot removed the ci-passed label Sep 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@mergify mergify bot added the ci-passed label Sep 5, 2023
@xiaofan-luan xiaofan-luan added this to the 2.3.1 milestone Sep 6, 2023
@mergify mergify bot added ci-passed and removed ci-passed labels Sep 6, 2023
@mergify mergify bot removed the ci-passed label Sep 6, 2023
@czs007
Copy link
Collaborator

czs007 commented Sep 6, 2023

/approve

@czs007
Copy link
Collaborator

czs007 commented Sep 6, 2023

/lgtm

@sre-ci-robot sre-ci-robot removed the lgtm label Sep 6, 2023
@czs007
Copy link
Collaborator

czs007 commented Sep 6, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Sep 6, 2023
@sre-ci-robot sre-ci-robot merged commit 2868127 into milvus-io:master Sep 6, 2023
@mergify mergify bot added the ci-passed label Sep 6, 2023
@SimFG SimFG mentioned this pull request Sep 6, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 left review comments

@bigsheeper bigsheeper bigsheeper left review comments

@wayblink wayblink wayblink approved these changes

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

@weiliu1031 weiliu1031

Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
7 participants
@SimFG @weiliu1031 @czs007 @sre-ci-robot @wayblink @bigsheeper @xiaofan-luan