Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the retry of the rpc client #26797

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Sep 1, 2023

issue: #26793
pr: #26795

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/L Denotes a PR that changes 100-499 lines. labels Sep 1, 2023
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Sep 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@SimFG Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@SimFG SimFG force-pushed the new-rpc-retry-2.2.0 branch from e15438e to d30dfe0 Compare September 1, 2023 02:49
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Sep 1, 2023
@SimFG SimFG force-pushed the new-rpc-retry-2.2.0 branch 2 times, most recently from 6cfe2be to a7f9d80 Compare September 1, 2023 03:36
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG SimFG force-pushed the new-rpc-retry-2.2.0 branch 3 times, most recently from b38d122 to d2453b4 Compare September 1, 2023 12:51
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG SimFG force-pushed the new-rpc-retry-2.2.0 branch from d2453b4 to 4f3cf64 Compare September 2, 2023 03:13
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG SimFG force-pushed the new-rpc-retry-2.2.0 branch from 4f3cf64 to 656b471 Compare September 2, 2023 05:34
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG SimFG force-pushed the new-rpc-retry-2.2.0 branch 3 times, most recently from dad550b to 5b6112c Compare September 2, 2023 08:17
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG SimFG force-pushed the new-rpc-retry-2.2.0 branch from 5b6112c to 9a0ed9d Compare September 2, 2023 12:49
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@SimFG SimFG force-pushed the new-rpc-retry-2.2.0 branch from 9a0ed9d to 73ee79c Compare September 2, 2023 14:41
@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2023

@SimFG ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #26797 (9b36713) into 2.2.0 (8ee4ca5) will increase coverage by 0.04%.
Report is 2 commits behind head on 2.2.0.
The diff coverage is 80.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #26797      +/-   ##
==========================================
+ Coverage   80.93%   80.98%   +0.04%     
==========================================
  Files         745      745              
  Lines      109188   109111      -77     
==========================================
- Hits        88372    88360      -12     
+ Misses      17463    17401      -62     
+ Partials     3353     3350       -3     
Files Changed Coverage Δ
internal/distributed/datacoord/client/client.go 74.06% <ø> (-0.05%) ⬇️
internal/distributed/datanode/client/client.go 77.24% <ø> (-0.12%) ⬇️
internal/distributed/indexcoord/client/client.go 52.84% <ø> (-0.25%) ⬇️
internal/distributed/indexnode/client/client.go 76.37% <ø> (-0.19%) ⬇️
internal/distributed/proxy/client/client.go 86.95% <ø> (-0.09%) ⬇️
internal/distributed/querycoord/client/client.go 80.37% <ø> (-0.06%) ⬇️
internal/distributed/querynode/client/client.go 90.94% <ø> (-0.04%) ⬇️
internal/distributed/rootcoord/client/client.go 90.87% <ø> (-0.43%) ⬇️
internal/querycoordv2/server.go 77.54% <0.00%> (ø)
internal/util/grpcclient/client.go 75.00% <78.66%> (+1.90%) ⬆️
... and 5 more

... and 18 files with indirect coverage changes

@SimFG
Copy link
Contributor Author

SimFG commented Sep 3, 2023

rerun ut

@mergify mergify bot added the ci-passed label Sep 3, 2023
@SimFG SimFG force-pushed the new-rpc-retry-2.2.0 branch from 73ee79c to a4160c7 Compare September 4, 2023 07:25
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Sep 4, 2023
@mergify mergify bot added ci-passed and removed ci-passed labels Sep 4, 2023
@SimFG SimFG force-pushed the new-rpc-retry-2.2.0 branch from a4160c7 to 9b36713 Compare September 11, 2023 02:45
@mergify mergify bot removed the ci-passed label Sep 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Sep 11, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 11, 2023
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approved

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6023bcb into milvus-io:2.2.0 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants