fix: expand privilege group when list policy in rootcoord #38758
Conversation
mergify
bot
added
dco-passed
shaoting-huang
force-pushed
the
list_policy
branch
from
237fbcf to
f80eefb
Compare
shaoting-huang
force-pushed
the
list_policy
branch
2 times, most recently
from
adc03e8 to
bf31aed
Compare
|
@shaoting-huang go-sdk check failed, comment |
|
@shaoting-huang cpp-unit-test check failed, comment |
shaoting-huang
force-pushed
the
list_policy
branch
from
bf31aed to
b15ec65
Compare
|
@shaoting-huang cpp-unit-test check failed, comment |
internal/rootcoord/root_coord.go
Outdated
| // expand privilege groups and turn to policies | ||
| allGroups, err := c.getPrivilegeGroups(ctx) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
According to the code above, the error is supposed to be returned by a wrapped response. Is it safe to return a nil response here?
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
force-pushed
the
list_policy
branch
from
b15ec65 to
1acc740
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaoting-huang, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38758 +/- ##
==========================================
- Coverage 81.08% 79.02% -2.06%
==========================================
Files 1381 1373 -8
Lines 195289 194075 -1214
==========================================
- Hits 158345 153370 -4975
- Misses 31354 35150 +3796
+ Partials 5590 5555 -35
|
cherry-pick from: #38758 related: #38757 Signed-off-by: shaoting-huang <[email protected]>
cherry-pick from: #38758 related: #38757 Signed-off-by: shaoting-huang <[email protected]>
related: #38757