Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] expand privilege group when list policy in rootcoord #38760

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

shaoting-huang
Copy link
Contributor

cherry-pick from: #38758
related: #38757

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 25, 2024
@shaoting-huang shaoting-huang force-pushed the list_policy_2.5 branch 2 times, most recently from aece209 to 15e5beb Compare December 25, 2024 14:48
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (d47372e) to head (d65c25b).
Report is 2 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38760      +/-   ##
==========================================
- Coverage   81.05%   81.04%   -0.01%     
==========================================
  Files        1381     1381              
  Lines      195158   195185      +27     
==========================================
+ Hits       158186   158196      +10     
- Misses      31391    31423      +32     
+ Partials     5581     5566      -15     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.34% <ø> (ø)
Go 83.03% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/metastore/kv/rootcoord/kv_catalog.go 80.81% <100.00%> (+0.10%) ⬆️
internal/rootcoord/meta_table.go 83.30% <100.00%> (ø)
internal/rootcoord/root_coord.go 88.09% <100.00%> (+0.34%) ⬆️

... and 26 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 25, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 26, 2024
@tedxu
Copy link
Contributor

tedxu commented Dec 26, 2024

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Dec 26, 2024
@sre-ci-robot sre-ci-robot merged commit 147c6b0 into milvus-io:2.5 Dec 26, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants