Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] expand privilege group when list policy in rootcoord #38759

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

shaoting-huang
Copy link
Contributor

cherry-pick from: #38758
related: #38757

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. labels Dec 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 25, 2024
@czs007 czs007 added this to the 2.4.19 milestone Dec 25, 2024
@shaoting-huang shaoting-huang force-pushed the list_policy_2.4 branch 3 times, most recently from 839d257 to 316d14f Compare December 25, 2024 23:10
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.37%. Comparing base (b9eb396) to head (b81b248).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38759      +/-   ##
==========================================
+ Coverage   80.40%   83.37%   +2.97%     
==========================================
  Files        1077      809     -268     
  Lines      169610   143069   -26541     
==========================================
- Hits       136369   119283   -17086     
+ Misses      28744    19302    -9442     
+ Partials     4497     4484      -13     
Files with missing lines Coverage Δ
internal/metastore/catalog.go 100.00% <ø> (ø)
internal/metastore/kv/rootcoord/kv_catalog.go 82.20% <100.00%> (+0.10%) ⬆️
internal/rootcoord/meta_table.go 83.97% <100.00%> (ø)
internal/rootcoord/root_coord.go 87.93% <100.00%> (+0.34%) ⬆️

... and 307 files with indirect coverage changes

@tedxu
Copy link
Contributor

tedxu commented Dec 26, 2024

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 26, 2024
@sre-ci-robot sre-ci-robot merged commit 92c7f6a into milvus-io:2.4 Dec 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants