Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: the returned inserted id are identical. (Restful api) #27856

Closed
1 task done
shanghaikid opened this issue Oct 23, 2023 · 4 comments
Closed
1 task done

[Bug]: the returned inserted id are identical. (Restful api) #27856

shanghaikid opened this issue Oct 23, 2023 · 4 comments
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@shanghaikid
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

No response

Current Behavior

I inserted 10 items, but the returned insertIds are identical

 insert {
        code: 200,
        data: {
          insertCount: 10,
          insertIds: [
            445127262333941300,
            445127262333941300,
            445127262333941300,
            445127262333941300,
            445127262333941300,
            445127262333941300,
            445127262333941300,
            445127262333941300,
            445127262333941300,
            445127262333941300
          ]
        }
      }

Expected Behavior

As we know that the javascript engine(v8) doesn't support Int64 natively, so if we have int64 in the response, when serializing, it will be rounded by the js engine. and there is no way to fix this on the client side, because this is just an API, not the sdk.

I think milvus should return string other than int64 in the response.

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response

@shanghaikid shanghaikid added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 23, 2023
@shanghaikid
Copy link
Contributor Author

and this should be fixed as soon as possible, because most vector operations need id, eg: get, delete operations, the server should handle not only the int64 id in the response, but also the string id in the request.

@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 23, 2023
@yanliang567 yanliang567 added this to the 2.3.2 milestone Oct 23, 2023
@yanliang567 yanliang567 removed their assignment Oct 23, 2023
@yanliang567 yanliang567 modified the milestones: 2.3.2, 2.3.3 Nov 3, 2023
@yanliang567 yanliang567 modified the milestones: 2.3.3, 2.3.4 Nov 16, 2023
Copy link

stale bot commented Dec 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 17, 2023
@yanliang567
Copy link
Contributor

@shanghaikid please help to verify the fix
/assign @shanghaikid

@stale stale bot removed the stale indicates no udpates for 30 days label Dec 19, 2023
@shanghaikid
Copy link
Contributor Author

it was fixed in v2.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants