Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated label for protos #202

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

jiaoew1991
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 12, 2023
@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo October 12, 2023 20:58
@mergify mergify bot added dco-passed DCO check passed. ci-passed labels Oct 12, 2023
@yhmo
Copy link
Collaborator

yhmo commented Oct 20, 2023

/approve
/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yhmo
Copy link
Collaborator

yhmo commented Oct 26, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit 2b0b91b into milvus-io:master Oct 26, 2023
3 checks passed
sre-ci-robot pushed a commit to milvus-io/milvus that referenced this pull request Jan 16, 2024
issue: [#30000](#30000)
related to: [milvus-proto
#202](milvus-io/milvus-proto#202)
master pr: #30002

1. replace collSchema.AutoID with primaryField.AutoID
2. show `enableDynamic` & `enableDynamicField` at the same time
3. avoid data race about the access to metacache

Signed-off-by: PowderLi <[email protected]>
sre-ci-robot pushed a commit to milvus-io/milvus that referenced this pull request Jan 18, 2024
issue: #30000
related to: [milvus-proto
#202](milvus-io/milvus-proto#202)

1. replace collSchema.AutoID with primaryField.AutoID
2. show `enableDynamic` & `enableDynamicField` at the same time
3. avoid data race about the access to metacache

Signed-off-by: PowderLi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants