-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecated label for protos #202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-ci-robot
added
the
kind/improvement
Changes related to something improve, likes ut and code refactor
label
Oct 12, 2023
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiaoew1991, yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jiaoew1991
force-pushed
the
add-deprecation-tag
branch
from
October 20, 2023 16:01
9497592
to
0213ce3
Compare
Signed-off-by: Enwei Jiao <[email protected]>
jiaoew1991
force-pushed
the
add-deprecation-tag
branch
from
October 24, 2023 16:16
0213ce3
to
6af2c31
Compare
/lgtm |
This was referenced Jan 15, 2024
sre-ci-robot
pushed a commit
to milvus-io/milvus
that referenced
this pull request
Jan 16, 2024
issue: [#30000](#30000) related to: [milvus-proto #202](milvus-io/milvus-proto#202) master pr: #30002 1. replace collSchema.AutoID with primaryField.AutoID 2. show `enableDynamic` & `enableDynamicField` at the same time 3. avoid data race about the access to metacache Signed-off-by: PowderLi <[email protected]>
sre-ci-robot
pushed a commit
to milvus-io/milvus
that referenced
this pull request
Jan 18, 2024
issue: #30000 related to: [milvus-proto #202](milvus-io/milvus-proto#202) 1. replace collSchema.AutoID with primaryField.AutoID 2. show `enableDynamic` & `enableDynamicField` at the same time 3. avoid data race about the access to metacache Signed-off-by: PowderLi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
ci-passed
dco-passed
DCO check passed.
kind/improvement
Changes related to something improve, likes ut and code refactor
lgtm
size/XXL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind improvement