Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CHERRY-PICK] CollectionSchema.autoID is deprecated #30011

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

PowderLi
Copy link
Contributor

issue: #30000
related to: milvus-proto #202
master pr: #30002

  1. replace collSchema.AutoID with primaryField.AutoID
  2. show enableDynamic & enableDynamicField at the same time
  3. avoid data race about the access to metacache

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 16, 2024
Copy link
Contributor

mergify bot commented Jan 16, 2024

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0447ef5) 82.22% compared to head (9bef8b0) 82.20%.
Report is 2 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30011      +/-   ##
==========================================
- Coverage   82.22%   82.20%   -0.02%     
==========================================
  Files         834      834              
  Lines      120405   120408       +3     
==========================================
- Hits        98998    98982      -16     
- Misses      18183    18203      +20     
+ Partials     3224     3223       -1     
Files Coverage Δ
internal/proxy/meta_cache.go 89.68% <100.00%> (-0.53%) ⬇️
internal/distributed/proxy/httpserver/utils.go 84.78% <0.00%> (ø)
...nternal/distributed/proxy/httpserver/handler_v1.go 91.44% <77.77%> (+0.13%) ⬆️

... and 12 files with indirect coverage changes

@yanliang567
Copy link
Contributor

/run-cpu-e2e

@yanliang567 yanliang567 added this to the 2.3.5 milestone Jan 16, 2024
1. replace collSchema.AutoID with primaryField.AutoID
2. add a mew param `enableDynamicField` for create collection api
3. avoid data race about the access to metacache

Signed-off-by: PowderLi <[email protected]>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 16, 2024
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jan 16, 2024
@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2024

/approve

@czs007
Copy link
Collaborator

czs007 commented Jan 16, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ff93e8b into milvus-io:2.3 Jan 16, 2024
13 of 14 checks passed
@PowderLi PowderLi deleted the 2.3-autoid-fix branch January 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants