Use reccomened gui_hooks for playAudio JS bridge to avoid affecting other addons #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #92
Hi,
I'm developing an Anki addon and I found how Migaku is "hijacking" the private AnkiWebView _onBridgeCmd prevents a JS callback from being called when handing a
pycmd
on new webviews.The real issue is that prevBridgeReroute in main.py should have a return statement on the last line, like this, so the results can be passed to a JavaScript callback.
But, the docs recommended using
gui_hooks.webview_did_receive_js_message
here which I think is the cleaner choice. When I make this change, it resolves the issue. Did a test on my Linux machine and the on-click audio still works as expected.https://addon-docs.ankiweb.net/#/hooks-and-filters?id=webview
webview.py in Anki also discourages setting _onBridgeCmd and onBridgeCmd manually:
I'd be happy to make a small addon to show further reproduction steps if needed.