Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grabbing _onBridgeCmd interfereing with other addons using JS bridge #92

Open
2 of 6 tasks
jamesrwaugh opened this issue Jul 31, 2021 · 0 comments
Open
2 of 6 tasks

Comments

@jamesrwaugh
Copy link

Type:

  • bug
  • feature
  • enhancement
  • question

Environment:

  • OS: Ubuntu 21.04
  • (Working on testing fix on Windows 10)

I'm going to open a PR to resolve the issue:

  • yes
  • no

Description:

(Following the contribution guidelines, opening an issue for a pull request I already submitted)

See description on the PR here: #91
Basically, I found that according to the Anki docs, Migaku should be using gui_hooks for its use of JS bridges in webviews. As it stands, other addons creating their own webviews will have issues when installed alongside Migaku.
I believe the Anki docs refer to this as "monkey patching" and is discouraged due to unpredictable side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant