You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
(Following the contribution guidelines, opening an issue for a pull request I already submitted)
See description on the PR here: #91
Basically, I found that according to the Anki docs, Migaku should be using gui_hooks for its use of JS bridges in webviews. As it stands, other addons creating their own webviews will have issues when installed alongside Migaku.
I believe the Anki docs refer to this as "monkey patching" and is discouraged due to unpredictable side effects.
The text was updated successfully, but these errors were encountered:
Type:
Environment:
I'm going to open a PR to resolve the issue:
Description:
(Following the contribution guidelines, opening an issue for a pull request I already submitted)
See description on the PR here: #91
Basically, I found that according to the Anki docs, Migaku should be using gui_hooks for its use of JS bridges in webviews. As it stands, other addons creating their own webviews will have issues when installed alongside Migaku.
I believe the Anki docs refer to this as "monkey patching" and is discouraged due to unpredictable side effects.
The text was updated successfully, but these errors were encountered: