Initialize #1
Initialize #1
Conversation
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "appDomain": "denied" | |||
There was a problem hiding this comment.
📝 Need to file an issue to investigate whether this is required.
| try | ||
| { | ||
| ExecutionMessageSink.OnMessage(new TestAssemblyStarting(testCases, TestAssembly, DateTime.Now, GetTestFrameworkEnvironment(), GetTestFrameworkDisplayName())); | ||
| ExecutionMessageSink.OnMessage(new TestCollectionStarting(testCases, testCollection)); |
There was a problem hiding this comment.
📝 Need to file an issue to investigate whether the test collection messages can be passed through from child test processes.
| internal class VisualStudioInstance | ||
| { | ||
| private readonly IntegrationService _integrationService; | ||
| private readonly IpcChannel _integrationServiceChannel; |
There was a problem hiding this comment.
📝 Need to file an issue to investigate the use of WCF instead of .NET Remoting.
| Directory.CreateDirectory(temporaryFolder); | ||
|
|
||
| var integrationTestServiceExtension = ExtractIntegrationTestServiceExtension(temporaryFolder); | ||
| var extensions = new[] { integrationTestServiceExtension }; |
There was a problem hiding this comment.
📝 This will need to be extensible before the test harness can be used for cross-version testing.
| <?xml version="1.0" encoding="utf-8"?> | ||
| <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011"> | ||
| <Metadata> | ||
| <Identity Id="Microsoft.VisualStudio.IntegrationTestService" Version="1.0.0" Language="en-US" Publisher="Microsoft" /> |
There was a problem hiding this comment.
📝 This extension will not actually be published to the Visual Studio gallery. Need to figure out if this can be expressed in VSIX v3 (without breaking VS2012 support).
| <TargetFramework>net452</TargetFramework> | ||
| <Platforms>x86</Platforms> | ||
|
|
||
| <VSInstallRoot>$(Registry:HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\VisualStudio\11.0@InstallDir)</VSInstallRoot> |
There was a problem hiding this comment.
📝 Currently, building this project requires the user have Visual Studio 2012, 2013, 2015, and 2017 installed. Need to figure out a way to get the necessary dependencies on NuGet or MyGet so we can avoid this.
| <ItemGroup> | ||
| <Reference Include="Microsoft.VisualStudio.ExtensionEngine" HintPath="$(MSBuildProgramFiles32)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Microsoft.VisualStudio.ExtensionEngine.dll" Private="false" /> | ||
| <Reference Include="Microsoft.VisualStudio.ExtensionManager" HintPath="$(MSBuildProgramFiles32)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\PrivateAssemblies\Microsoft.VisualStudio.ExtensionManager.dll" Private="false" /> | ||
| <Reference Include="Microsoft.VisualStudio.ExtensionManager.Implementation" HintPath="$(MSBuildProgramFiles32)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\PrivateAssemblies\Microsoft.VisualStudio.ExtensionManager.Implementation.dll" Private="false" /> |
There was a problem hiding this comment.
📝 Hard-coded dependency paths.
| [MethodImpl(MethodImplOptions.InternalCall)] | ||
| void GetAssetProperties( | ||
| [In] [MarshalAs(UnmanagedType.LPWStr)] string szAssetTypeName, | ||
| [MarshalAs(UnmanagedType.SafeArray, SafeArraySubType = VarEnum.VT_BSTR)] out Array prgsaNames, |
There was a problem hiding this comment.
💭 It should be possible to use string[] instead of Array for these...
Initial implementation of the xUnit.net test harness for integration testing Visual Studio extensions.