fix(react-test-utils): fix remaining integration issues #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
September 16, 2024 15:53
…to user/stwilczy/fixJest
kerrynf
approved these changes
Sep 17, 2024
| @@ -19,3 +19,5 @@ Then inside your package.json add the compiler to your `scripts`: | |||
| } | |||
| } | |||
| ``` | |||
|
|
|||
There was a problem hiding this comment.
This sounds like something we should fix?
There was a problem hiding this comment.
I agree but who has funding to fix it? I created an issue a while back in microsoft/graphitation#331
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "noUnusedLocals": false, |
There was a problem hiding this comment.
// prevents error about graphql import not being used when artifacts are loaded
This looks like it moved from further down, where it had this comment? Is this the reason this is being added here? Should we include the comment?
There was a problem hiding this comment.
I realized it makes more sense to have local test specific tsconfigs, instead of using a big one. I will make a small PR to improve it even further and add some explanations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #108 we partially fixed some issues, as imports still not work correctly due to wrong imports map and there was an error thrown when opening storybook on jest being used directly. Here we aim to fix these by:
moduleResolution: "Bundler'needed for exports map (apart from compiler which needs to stay on 4.x) - this also required bumping @graphitation dependencies and making sure we can use per package tsconfig for testsVerified changes using local storybook and by making a patch in 1JS