fix(examples): improve handling of local jest config and remove RTL clean hack #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerrynf
reviewed
Sep 18, 2024
| transform: { | ||
| "\\.(gql|graphql)$": "@graphql-tools/jest-transform", | ||
| // Needed for packages/examples to load relay compiler generated artifacts. | ||
| // It would be better if it could be config local to examples package but haven't found a way to configure it with just |
There was a problem hiding this comment.
It looks like it is local to the examples package? Am I missing something or does the comment need to be updated?
There was a problem hiding this comment.
Right, I mindlessly copy pasted, will remove on next PR
kerrynf
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on a comment from #109 we improved handling of having package specific configurations:
examplespackagejest.setupAfterEnvfile by using/pureimports from RTL