Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VHD GetNotifications RPC Changes #296

Merged
merged 3 commits into from
Oct 31, 2024
Merged

VHD GetNotifications RPC Changes #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8eb8af1
added vhd getnotif string arg
nikohobart Oct 24, 2024
8760ca4
added new error codes for new scenarios
nikohobart Oct 24, 2024
9c1572e
changed error codes for volumes
nikohobart Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/errors/codes/codes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ const (
MeasurementUnitError
QuotaViolation
IPOutOfRange
VolumeNotFound
VolumeDegraded
VolumeAccessInconsistent

// This is not a valid code, it is used to get the maximum code value.
// Any new codes should be defined above this.
Expand Down
6 changes: 6 additions & 0 deletions pkg/errors/codes/codes_string.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ func (c MocCode) String() string {
return "QuotaViolation"
case IPOutOfRange:
return "IPOutOfRange"
case VolumeNotFound:
return "VolumeNotFound"
case VolumeDegraded:
return "VolumeDegraded"
case VolumeAccessInconsistent:
return "VolumeAccessInconsistent"
default:
return "MocCode(" + strconv.FormatUint(uint64(c), 10) + ")"
}
Expand Down
183 changes: 112 additions & 71 deletions rpc/nodeagent/storage/moc_nodeagent_virtualharddisk.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions rpc/nodeagent/storage/virtualharddisk/moc_nodeagent_virtualharddisk.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ message VirtualHardDisk {
DiskFileFormat diskFileFormat = 23;
}

message DiskNotificationRequest {
string resourceType = 1;
}

service VirtualHardDiskAgent {
rpc Invoke(VirtualHardDiskRequest) returns (VirtualHardDiskResponse) {}
rpc CheckNotification(google.protobuf.Empty) returns (NotificationResponse) {}
}
rpc CheckNotification(DiskNotificationRequest) returns (NotificationResponse) {}
}
Loading