Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VHD GetNotifications RPC Changes #296

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

nikohobart
Copy link
Contributor

@nikohobart nikohobart commented Sep 19, 2024

Changes Introduced by this PR

  • Revised nodeagent vhd GetNotifications to enable feeding notifications into cloudagent VHD, Gallery Image, and VM Image.
  • Adds error codes for new volume-related error scenarios.

Test Plan

@nikohobart nikohobart changed the title Error Propagation and VHD RPC Changes VHD RPC Changes Sep 30, 2024
@nikohobart nikohobart changed the title VHD RPC Changes VHD GetNotifications RPC Changes Sep 30, 2024
@nikohobart nikohobart force-pushed the user/nhobart/vhd-error-prop branch 2 times, most recently from 8d3516e to 14d996c Compare October 7, 2024 14:33
madhanrm
madhanrm previously approved these changes Oct 28, 2024
pkg/errors/codes/codes.go Outdated Show resolved Hide resolved
@nikohobart
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nikohobart
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nikohobart nikohobart merged commit b70f2f0 into main Oct 31, 2024
6 checks passed
connievi pushed a commit that referenced this pull request Nov 12, 2024
* added vhd getnotif string arg

* added new error codes for volume issue scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants