Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macos callout text run anchoring #3661

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Macos callout text run anchoring #3661

wants to merge 12 commits into from

Commits on Jun 19, 2024

  1. Preview of CalloutView MacOS changes for text anchoring to text runs

    @PPatBoyd
    PPatBoyd committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4ee8175 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/microsoft/fluentui-react-na… 

    …tive into macosCalloutTextRunAnchoring
    @PPatBoyd
    PPatBoyd committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    74d7bfd View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Clean up implementation of CalloutView anchoring to nested text runs

    @PPatBoyd
    PPatBoyd committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    90a826b View commit details
    Browse the repository at this point in the history

  2. Improve test page for CalloutTest for cross-plat text run anchor testing

    @PPatBoyd
    PPatBoyd committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ddcb94c View commit details
    Browse the repository at this point in the history

  3. Change files

    @PPatBoyd
    PPatBoyd committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    35a9268 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Fix ref type used for Textv1

    @PPatBoyd
    PPatBoyd committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    61181fb View commit details
    Browse the repository at this point in the history

  2. Bump react-native-macos to use latest 0.73.32 version that includes g… 

    …etRectForCharRange used by CalloutView.swift
    @PPatBoyd
    PPatBoyd committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    9861139 View commit details
    Browse the repository at this point in the history

  3. address PR feedback and some other nit cleanup

    @PPatBoyd
    PPatBoyd committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b00627d View commit details
    Browse the repository at this point in the history

  4. yarn prettier-fix

    @PPatBoyd
    PPatBoyd committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    5e2111f View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. nit fix whitespaces

    @PPatBoyd
    PPatBoyd committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e621f66 View commit details
    Browse the repository at this point in the history

  2. better stacked guard usage

    @PPatBoyd
    PPatBoyd committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    3495b9d View commit details
    Browse the repository at this point in the history

  3. Swift-ier function signatures and CGRect.zero

    @PPatBoyd
    PPatBoyd committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8298834 View commit details
    Browse the repository at this point in the history