Macos callout text run anchoring #3661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tive into macosCalloutTextRunAnchoring
|
Note: this PR will be broken until it can take a new version of RN-MacOS with dependent changes. Making available for review and discussion ahead of that integration. |
Saadnajmi
reviewed
Jun 20, 2024
Saadnajmi
reviewed
Jun 20, 2024
Saadnajmi
reviewed
Jun 20, 2024
…etRectForCharRange used by CalloutView.swift
amgleitman
reviewed
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Enable anchoring to nested MacOS text runs
Verification
Manually verified with new anchor targets on Callout test page
Pull request checklist
This PR has considered (when applicable):