Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflows #4476

Merged
merged 3 commits into from
Mar 16, 2024
Merged

Conversation

StephanTLavavej
Copy link
Member

  • Delete GitHub workflows for the old Code Reviews project.
    • "Assign new PRs" is built-in functionality for new-style projects - except for the draft distinction, which we can live without.
    • The /pr wip and /pr review commands were rarely used by contributors, and now that the backlog is much smaller, they aren't worth replacing/maintaining. (I believe they broke when MS started requiring permissions and I didn't grant them in Add permissions to the Assign New PR action #4223.)
  • update-status-chart.yml: .ts => .mts
  • Update node-version to 21.7.1.
    • Updating this version is always "nice to have" - the infrastructure usually retrieves the latest (and is already retrieving 21.7.1). I just don't want to let it get too outdated, in case some stale version starts getting selected from a cache, significantly diverging from what I'm locally using.

⚠️ Note to self:

After merging, we should update the repo's settings for Actions Permissions.

StephanTLavavej and others added 3 commits March 12, 2024 14:09
"Assign new PRs" is built-in functionality for new-style projects - except for the draft distinction, which we can live without.

The `/pr wip` and `/pr review` commands were rarely used by contributors, and now that the backlog is much smaller, they aren't worth replacing/maintaining.

Note: After merging, we should update the repo's settings for Actions Permissions.
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Mar 13, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 13, 2024 09:06
@StephanTLavavej StephanTLavavej self-assigned this Mar 15, 2024
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 191d51b into microsoft:main Mar 16, 2024
37 checks passed
@StephanTLavavej StephanTLavavej deleted the workflows branch March 16, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants