Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Chart: Modernize modules, chart.js 4.4.2 #4460

Merged
merged 13 commits into from
Mar 16, 2024

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Mar 9, 2024

In addition to weekly updates, and minor dependency updates including chart.js 4.4.2 (no visible changes), this picks up a major update: octokit/graphql.js#549 . Now that @octokit/graphql is ESM (ECMAScript Modules), we need to overhaul how the gather_stats script imports things. For consistency, this also cleans up status_chart, although it was halfway there already.

Back in TypeScript 4.5 (which we picked up in #2348), the extension .mts was introduced, to explicitly indicate that ESM is being used for TypeScript, mirroring the .mjs extension for JavaScript. So I'm renaming our files:

  • gather_stats: .ts => .mts, .js => .mjs
  • status_chart: .ts => .mts
    • We were already emitting status_chart.mjs for the browser.
  • daily_table, weekly_table, monthly_table: .ts => .mts

Finally, we need to update how we consume and resolve modules:

As usual, this contains a "DROP BEFORE MERGING" commit to make the live preview work, which will accumulate merge conflicts.

📉 Live preview: stephantlavavej.github.io/STL/

⚠️ Note to self:

#4476 updates .github/workflows/update-status-chart.yml in main for these renames.

@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Mar 9, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 9, 2024 10:19
@StephanTLavavej StephanTLavavej merged commit 7e8b4af into microsoft:gh-pages Mar 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants