CI: build with VS2019 toolset for Windows #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This (compared to using the latest VS2022, as we currently do) increases the chance that pymmcore will work with whatever version of the C++ runtime that gets loaded (possibly by other modules imported before us). It may also help with installed by pip into a Conda environment, though that is not a recommended use case.
|
Running @tlambert03's test script (#119) with |
marktsuchida
force-pushed
the
use-vs2019-toolset
branch
from
dee6d5b to
3f9e368
Compare
|
Incidentally, we're already building using macos-12 (rather than macos-13 or 14) for macOS, which is probably good for compatibility reasons. |
|
awesome! easy fix! thanks @marktsuchida |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (compared to using the latest VS2022, as we currently do) increases the chance that pymmcore will work with whatever version of the C++ runtime that gets loaded (possibly by other modules imported before us). It may also help when installed by pip into a Conda environment, though that is not a recommended use case.
Hopefullycloses #119.