Relax check against setting a pre-init property after initialization #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change: Setting a pre-init property after initialization is an error. After this change: Setting a pre-init property after initialization is an error if Core feature StrictInitializationChecks is enabled. Otherwise it is a warning. Bump MMCore version to 11.1.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change: Setting a pre-init property after initialization is an error.
After this change: Setting a pre-init property after initialization is an error if Core feature StrictInitializationChecks is enabled. Otherwise it is a warning.
Bump MMCore version to 11.1.1.
(We probably need to special case SerialManager ports, to allow port scanning to work. But for now remove the error for all devices to give us time to decide what exactly needs to be allowed.)
Related to: #384 (comment)