PICARD-2946: metainfo: fix recommended display length definition #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-relations-display_length, display length's value must be an integer value corresponding to logical pixels. I took `768`px as value because it corresponds to the recommended referenced size for laptops and tablets, which should match imho the previous incorrect `medium` value. This fix flathub's build as they don't allow releasing builds with invalid appdata (even if it's just a warning). Running `appstreamcli validate` do raise this warning: `W: org.musicbrainz.Picard:318: relation-display-length-value-invalid medium` currently.
phw
approved these changes
Apr 24, 2024
phw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Currently, flathub's build are failing as they don't allow releasing builds with invalid appdata (even if it's just a warning). Running
appstreamcli validatedo raise this warning:W: org.musicbrainz.Picard:318: relation-display-length-value-invalid mediumcurrently.According to https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-relations-display_length, display length's value must be an integer value corresponding to logical pixels.
Solution
I took
768px as value because it corresponds to the recommended referenced size for laptops and tablets, which should match imho the previous incorrectmediumvalue.Action
Additional actions required: