Skip to content

Commit

Permalink
metainfo: fix recommended display length definition
Browse files Browse the repository at this point in the history
According to https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-relations-display_length, display length's value must be an integer value corresponding to logical pixels.

I took `768`px as value because it corresponds to the recommended referenced size for laptops and tablets, which should match imho the previous incorrect `medium` value.

This fix flathub's build as they don't allow releasing builds with invalid appdata (even if it's just a warning). Running `appstreamcli validate` do raise this warning: `W: org.musicbrainz.Picard:318: relation-display-length-value-invalid medium` currently.
  • Loading branch information
Lctrs authored and phw committed Apr 24, 2024
1 parent eec6513 commit ae0b2b2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion org.musicbrainz.Picard.appdata.xml.in
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
<recommends>
<control>keyboard</control>
<control>pointing</control>
<display_length compare="ge">medium</display_length>
<display_length compare="ge">768</display_length>
<internet>always</internet>
</recommends>

Expand Down

0 comments on commit ae0b2b2

Please sign in to comment.