PICARD-2746: localize XDG desktop file #2298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The XDG desktop file (used for offering the menu entry on compliant desktop environments, e.g. on Linux and BSD) is currently not localized, but can be.
Solution
org.musicbrainz.Picard.desktop
file to aorg.musicbrainz.Picard.desktop.in
template file.po/appstream
usingmsgfmt
as part ofregen_appdata_pot_file
setup command.build_desktop_file
command forsetup.py
to compile the translatedorg.musicbrainz.Picard.desktop
file from theorg.musicbrainz.Picard.desktop.in
template.I decided here to use the same gettext resource for the desktop file as for the AppStream metadata. My reasoning is as follows:
.po
files never get separately compiled into.mo
files and no translations files get installed onto the target system (as all translations become part of the generated file)