Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict default permissions of Github Actions #2299

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

phw
Copy link
Member

@phw phw commented Sep 6, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

See discussion at #2298 (comment)

@phw phw force-pushed the gha-restrict-permissions branch from ac75f66 to bab30fd Compare September 6, 2023 14:01
@phw phw force-pushed the gha-restrict-permissions branch from bab30fd to 3e3e349 Compare September 6, 2023 14:02
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@phw phw marked this pull request as ready for review September 8, 2023 05:32
@phw
Copy link
Member Author

phw commented Sep 8, 2023

It looks good to me.

Yes, I guess it is. At least everything seems to work. The release task should also work with the set permissions, but we'll see on next tagged release. Worst case I have to create the Github release manually.

@phw phw merged commit 9009771 into master Sep 8, 2023
104 checks passed
@phw phw deleted the gha-restrict-permissions branch September 8, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants