Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ item about manually adding lyrics to a file #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rdswift
Copy link
Collaborator

@rdswift rdswift commented Mar 9, 2022

Summary

This is a…

  • Correction
  • Addition
  • Restructuring
  • Minor / simple change (like a typo)
  • Other

Reason for the Change

Question about adding lyrics comes up from time to time in the forums.

Description of the Change

Add FAQ response for the question, using the response by outsidecontext in https://community.metabrainz.org/t/how-to-manually-add-the-lyric-metadata/575945 as a basis.

Additional Action Required

None.

@rdswift rdswift added the documentation Improvements or additions to documentation label Mar 9, 2022
@rdswift rdswift requested a review from phw March 9, 2022 18:25
@rdswift rdswift self-assigned this Mar 9, 2022
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it makes sense, because lyrics being multi line might confuse users. At least in this case it even seems to have prevented the user to even try to add / paste the text.

On the other hand this is the general procedure to adding tags. Maybe the special thing is really the multiline thing?

Because same procedure applies to comments. Both lyrics and comments trigger special behavior in the tag editing that allows for entering multi line text. It is still a bit awkward to work with long texts in Picard.

So maybe have this FAQ a bit more generic? Or at least make it into "How do I manually add lyrics or comments to a file?"

@rdswift rdswift added the do not merge Do not merge until requirements are met label Mar 10, 2022
@rdswift
Copy link
Collaborator Author

rdswift commented Mar 10, 2022

TBH, I'm not really convinced this is needed.

As you suggest, perhaps it should be dropped in favour of a small section on using the tag editor in general. Believe it or not, I've never used that functionality, so I'll have to do some experimenting before I can document it. Do you have any suggestions on where this explanation would best fit in the document? I'm not sure the FAQ section is the right place.

@rdswift
Copy link
Collaborator Author

rdswift commented Mar 10, 2022

Just a note to remind me that the screen shot for whichever way we decide to go will need to be changed when metabrainz/picard#2077 is applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge until requirements are met documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants