Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpufaq #868

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add gpufaq #868

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d130f69
Update FAQ.md
sekyondaMeta Oct 20, 2023
19c1b38
Update README.md
sekyondaMeta Oct 20, 2023
0c3488d
Update FAQ.md
sekyondaMeta Oct 20, 2023
33e88b0
Update FAQ.md
sekyondaMeta Oct 23, 2023
e592f29
Update README.md
sekyondaMeta Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions FAQ.md
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we substantiate which generation of GPUs we are supporting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question is one of those that I have had trouble narrowing down. I will investigate a bit to find a more concrete answer, that said, I have added some verbiage from the recipes FAQ

Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,8 @@ Make sure to run the command as follows
A:
The issue occurs because of not copying the URL correctly. If you right click on the link and copy the link, the link may be copied with url defence wrapper.
To avoid this problem, please select the url manually and copy it


**Q: What GPU can I use to run the code in this repository?**

A: The code in this repository only supports NVIDIA GPUs.
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ torchrun --nproc_per_node 1 example_chat_completion.py \
- The `–nproc_per_node` should be set to the [MP](#inference) value for the model you are using.
- Adjust the `max_seq_len` and `max_batch_size` parameters as needed.
- This example runs the [example_chat_completion.py](example_chat_completion.py) found in this repository but you can change that to a different .py file.
- For best results we suggest you run the code in this repository on a **Linux Operating System with a NVIDIA GPU**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we are stronger here and say that only linux+Nvidia is supported at this time as opposed to 'for best results'...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.


## Inference

Expand Down