Add gpufaq #868
Open
Add gpufaq #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jspisak
reviewed
Oct 20, 2023
FAQ.md
Outdated
There was a problem hiding this comment.
Can we substantiate which generation of GPUs we are supporting?
There was a problem hiding this comment.
This question is one of those that I have had trouble narrowing down. I will investigate a bit to find a more concrete answer, that said, I have added some verbiage from the recipes FAQ
jspisak
reviewed
Oct 20, 2023
README.md
Outdated
| @@ -57,6 +57,7 @@ torchrun --nproc_per_node 1 example_chat_completion.py \ | |||
| - The `–nproc_per_node` should be set to the [MP](#inference) value for the model you are using. | |||
| - Adjust the `max_seq_len` and `max_batch_size` parameters as needed. | |||
| - This example runs the [example_chat_completion.py](example_chat_completion.py) found in this repository but you can change that to a different .py file. | |||
| - For best results we suggest you run the code in this repository on a **Linux Operating System with a NVIDIA GPU**. | |||
There was a problem hiding this comment.
Maybe we are stronger here and say that only linux+Nvidia is supported at this time as opposed to 'for best results'...
jspisak
requested changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding GPU requirements to FAQ and README