-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add plots to result #255
Conversation
…ture/add-plots-to-result
…ture/add-plots-to-result
…ture/add-plots-to-result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool feature! The PlotData
class is super useful :) I was able to run the test_spheres
recipe and generate simularium files with plots on the side!
Your PR description asks to set show_grid_plot
config to true
but I don't see it checked anywhere. Do you mean save_analyze_result
?
self.saveResult = "out" in config | ||
self.saveResult = ( | ||
"out" in config | ||
and not config["save_analyze_result"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have these additional conditions here? Wouldn't this prevent saving simularium files completely if there is more than one packing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's because the saving happens from the Analysis class instead of the Env class
ah right, I meant |
Problem
What is the problem this work solves, including
closes #254
Solution
histogram
withinAnalysis.py
, added the logic to insert plot data into result file. Set the argumentadd_to_result
to true and setsave_png
to false, by defaultsimularium_helper
, added plot data to the trajectory converter and had simularium io process the plot display on the websitewith @meganrm @mogres @ascibisz and Joe
Type of change
Steps to Verify:
save_analyze_result
config set totrue
to see if the plots display next to the result as expectedScreenshots (optional):