Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Stop saving thread_id in the data field of receipts_graph #16297

Closed
wants to merge 2 commits into from
Closed

Stop saving thread_id in the data field of receipts_graph #16297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
954ba95
Swap a get() to a pop(), so the field will not be persisted in two pl…
realtyem Sep 11, 2023
cec4036
changelog
realtyem Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/16297.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Stop saving `thread_id` in `data` for the `receipts_graph`.
2 changes: 1 addition & 1 deletion synapse/handlers/receipts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ async def _received_remote_receipt(self, origin: str, content: JsonDict) -> None

# Check if these receipts apply to a thread.
data = user_values.get("data", {})
thread_id = data.get("thread_id")
thread_id = data.pop("thread_id")
# If the thread ID is invalid, consider it missing.
if not isinstance(thread_id, str):
thread_id = None
Expand Down