Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Stop saving thread_id in the data field of receipts_graph #16297

Closed

Conversation

realtyem
Copy link
Contributor

@realtyem realtyem commented Sep 11, 2023

Noticed this while watching the Postgres logs, so went to look deeper and found
weird_receipt_graph_artifact

Which doesn't seem right. It's on a JsonDict, so it can be pop()ped instead of just being got().

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

Signed-off-by: Jason Little [email protected]

@realtyem realtyem marked this pull request as ready for review September 11, 2023 09:55
@realtyem realtyem requested a review from a team as a code owner September 11, 2023 09:55
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide more rationale for this? The thread ID is part of the data and should be stored as part of it.

We denormalize it so that we can easily query it.

@realtyem realtyem closed this Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants