Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/downloader: bypass peer validation if remote peer is far away #1167

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

manav2401
Copy link
Contributor

Don't stop sync if remote peer is far away (1024 blocks for now)

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v1.2.7-beta2-candidate@7d39405). Click here to learn what that means.

Files Patch % Lines
eth/downloader/downloader.go 72.72% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             v1.2.7-beta2-candidate    #1167   +/-   ##
=========================================================
  Coverage                          ?   55.96%           
=========================================================
  Files                             ?      658           
  Lines                             ?   114495           
  Branches                          ?        0           
=========================================================
  Hits                              ?    64073           
  Misses                            ?    46573           
  Partials                          ?     3849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manav2401 manav2401 merged commit e1c9119 into v1.2.7-beta2-candidate Feb 27, 2024
12 checks passed
@manav2401 manav2401 deleted the manav/bypass-peer-validation branch February 27, 2024 13:32
temaniarpit27 added a commit that referenced this pull request Feb 28, 2024
@manav2401 manav2401 restored the manav/bypass-peer-validation branch February 28, 2024 13:03
@manav2401 manav2401 deleted the manav/bypass-peer-validation branch April 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants