Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/downloader: bypass peer validation if remote peer is far away #1219

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

manav2401
Copy link
Contributor

Description

Adds modified version of #1167. While syncing if the remote peer is far away (1024 blocks), bypass the validation.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

@manav2401 manav2401 requested a review from a team April 13, 2024 08:36
@manav2401 manav2401 requested a review from Raneet10 April 15, 2024 08:09
Copy link
Member

@Raneet10 Raneet10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from minor nits, LGTM!

@manav2401
Copy link
Contributor Author

manav2401 commented Apr 15, 2024

Although e2e tests failed at upload logs but the smoke tests passed so looks good to go!

@manav2401 manav2401 merged commit a0c7d0c into develop Apr 15, 2024
9 of 12 checks passed
@manav2401 manav2401 deleted the manav/bypass-peer-validation-2 branch April 15, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants