Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests for operators #384

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

gc031298
Copy link
Contributor

Solving issue #382.

Tests on actual values and labels for each differential operator are added where missing. All operators are tested both on the whole set of input/output components, and on a representative subset.

@gc031298 gc031298 marked this pull request as ready for review November 22, 2024 18:05
@dario-coscia dario-coscia self-requested a review November 23, 2024 09:02
@dario-coscia dario-coscia added the pr-to-review Label for PR that are ready to been reviewed label Nov 23, 2024
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice integration! I added just commented on a minor change which needs to be addressed.

tests/test_operators.py Outdated Show resolved Hide resolved
@dario-coscia dario-coscia added pr-to-fix Label for PR that needs modification and removed pr-to-review Label for PR that are ready to been reviewed labels Nov 23, 2024
@gc031298
Copy link
Contributor Author

@dario-coscia The required changes have been applied. Please, review the new commit and, if everything is up to standards, merge.

@ndem0 ndem0 added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Nov 25, 2024
@ndem0 ndem0 linked an issue Nov 25, 2024 that may be closed by this pull request
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@dario-coscia dario-coscia merged commit 5e36d1b into mathLab:master Nov 25, 2024
16 checks passed
@dario-coscia dario-coscia deleted the op_tests branch November 25, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-to-review Label for PR that are ready to been reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional tests for operators
3 participants