Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postponed: Add MSVC setup to CI #210

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Postponed: Add MSVC setup to CI #210

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0132dfe
Add MSVC setup to CI
maxammann Nov 12, 2022
d04a187
Use cl without &
maxammann Nov 12, 2022
b4bff1e
Fix setting variables
maxammann Nov 12, 2022
8169958
Try to move msys2 back in the path variable
maxammann Nov 12, 2022
f592b76
Try to set msys2 through GITHUB_ENV
maxammann Nov 12, 2022
c390a9f
Show bash path
maxammann Nov 13, 2022
aa095de
Merge branch 'main' into msvc-ci-setup
maxammann Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions .github/workflows/demo-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,47 @@ jobs:
name: Build
runs-on: windows-2022
steps:
- name: Switch to msys2
shell: powershell
run: echo "C:\msys64\usr\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
- name: Setup MSVC
run: |
$script=@'
Push-Location "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build"
& "C:\Windows\System32\cmd.exe" /c "vcvars64.bat & set" |
ForEach-Object {
if ($_ -match "=") {
$v = $_.split("=", 2)

if ($($v[0]) -match "Path") {
echo "$($v[0])=$($v[1]);C:\msys64\usr\bin" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup this case. We are adding msys64 at the very last in the Path such that binaries like link.exe have a higher priority

} else {
echo "$($v[0])=$($v[1])" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
}
}
}
Pop-Location
'@
Out-File -FilePath .\msvc.ps1 -InputObject $script -Encoding utf8
& .\msvc.ps1
- name: Test MSVC
run: |
$test_program=@'
#include<stdio.h>

int main() {
printf("Hello World\n");
return 0;
}
'@
Out-File -FilePath .\test_program.c -InputObject $test_program -Encoding utf8
cl .\test_program.c
- name: Install mysys2 dependencies
shell: powershell
run: pacman -S --noconfirm unzip
- name: Show PATH
- name: Show Powershell PATH
shell: powershell
run: Write-Host $env:path
- name: Show bash PATH
shell: powershell
run: bash -c 'echo $PATH'
Comment on lines +49 to +51
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Currently the git bash is executed here. The Git bash also has a link.exe. Make sure that either Git bash or msys2 bash both prefer using the link.exe from MSVC.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: Use powershell to write to .bashrc and overwrite at least PATH variable.

- uses: actions/checkout@v3
- name: Setup
uses: ./.github/actions/setup
Expand Down