Postponed: Add MSVC setup to CI #210
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxammann
changed the title
maxammann
commented
Nov 12, 2022
.github/workflows/demo-windows.yml
Outdated
| $v = $_.split("=", 2) | ||
|
|
||
| if ($($v[0]) -match "Path") { | ||
| echo "$($v[0])=$($v[1]);C:\msys64\usr\bin" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append |
There was a problem hiding this comment.
Cleanup this case. We are adding msys64 at the very last in the Path such that binaries like link.exe have a higher priority
maxammann
commented
Nov 13, 2022
Comment on lines
+49
to
+51
| - name: Show bash PATH | ||
| shell: powershell | ||
| run: bash -c 'echo $PATH' |
There was a problem hiding this comment.
TODO: Currently the git bash is executed here. The Git bash also has a link.exe. Make sure that either Git bash or msys2 bash both prefer using the link.exe from MSVC.
There was a problem hiding this comment.
Idea: Use powershell to write to .bashrc and overwrite at least PATH variable.
maxammann
changed the title
maxammann
added
the
pr-postponed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setups the MSVC compiler in our CI. Right now we do not need it.
But as soon as we link for example against SQLite or OpenSSL we might need it again.
💻 Examples
🚨 Test instructions
✔️ PR Todo