Use applitools branches #2325
Merged
Use applitools branches #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmation that this changes on a branch still generate an test fail. |
samtygier-stfc
force-pushed
the
2324-applitools-branches
branch
from
6b35239 to
cfbf0ff
Compare
ashmeigh
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
I reviewed the PR and confirmed that the branch_name is correctly implemented for Applitools. Everything appears to be working as expected, and I found no issues. The implementation meets the acceptance criteria and should solve the baseline conflict problem.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2324
Description
Set the branch_name property to the name of the PR branch. This will cause applitools to consider these tests to be ona branch with their own baselines. This might solve the issue of conflicts when making GUI changes.
Acceptance Criteria
Overall we want a solution that. Its not easy to test this in advance on a PR, so we'll have to merge and then see how it works.
Documentation
Release notes