Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify datasets part 5 #2323

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Unify datasets part 5 #2323

merged 6 commits into from
Sep 24, 2024

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Sep 9, 2024

Issue

Work on #2199

Description

This begins the work of simplifying use of datasets, now that they have not functional difference.

Rename BaseDataset to Dataset.
Remove menu differences.
Check if the dataset has a sample, rather than if it is a StrictDataset. (this fixes errors that could occur if you remove delete a sample from dataset)
Remove some type unions

Testing & Acceptance Criteria

MI starts and can open data.
"Load 180" should be enabled in the menu if a dataset is loaded.

Documentation

Not yet

@samtygier-stfc
Copy link
Collaborator Author

Also using this PR to explore the changes from #2325 . Removing a test has triggered the expected "No current image" message on Applitools.

@coveralls
Copy link

Coverage Status

coverage: 74.342% (+0.005%) from 74.337%
when pulling 4cb12ea on 2199-unify-datasets-5
into 0948a45 on main.

@samtygier-stfc samtygier-stfc marked this pull request as ready for review September 10, 2024 15:04
@samtygier-stfc samtygier-stfc mentioned this pull request Sep 23, 2024
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass and all code changes look reasonable. Opened and loaded in various datasets to make sure they load in correctly. The "load 180" dialog works correctly when a dataset is loaded in. Other parts of MI work as usual.

@MikeSullivan7 MikeSullivan7 added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 1c1e090 Sep 24, 2024
8 checks passed
@MikeSullivan7 MikeSullivan7 deleted the 2199-unify-datasets-5 branch September 24, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants