-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify datasets part 5 #2323
Unify datasets part 5 #2323
Conversation
No difference between mixed and strict
7eec9d9
to
4cb12ea
Compare
Also using this PR to explore the changes from #2325 . Removing a test has triggered the expected "No current image" message on Applitools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass and all code changes look reasonable. Opened and loaded in various datasets to make sure they load in correctly. The "load 180" dialog works correctly when a dataset is loaded in. Other parts of MI work as usual.
Issue
Work on #2199
Description
This begins the work of simplifying use of datasets, now that they have not functional difference.
Rename BaseDataset to Dataset.
Remove menu differences.
Check if the dataset has a sample, rather than if it is a StrictDataset. (this fixes errors that could occur if you remove delete a sample from dataset)
Remove some type unions
Testing & Acceptance Criteria
MI starts and can open data.
"Load 180" should be enabled in the menu if a dataset is loaded.
Documentation
Not yet