-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify datasets part 1 #2288
Unify datasets part 1 #2288
Conversation
This remove the final features from MixedDataset
453431e
to
cf7bf35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having now tested a few times and gone over the code a few times, I'm happy to approve this. If you feel that a second courtesy review is needed, I would also agree with this given the code we are touching, otherwise can just merge in :)
I think its all going to get a bunch more testing over the next few PRs, so I'd suggest merging now |
Issue
Work on #2199
Description
This is the first step in unifying
MixedDataset
andStrictDataset
. This first step moves all the implementation ofMixedDataset
intoBaseDataset
.This required some changes that result in a small changes to the rest of the codebase
Forcing constructor arguments to named, because the current classes use different argument ordering
Forcing access to the recons through a property.
Testing
I have moved the
MixedDataset
andStrictDataset
tests into core.I have added a DatasetTest, currently for BaseDataset. This will duplicate tests from the other test classes, and eventually replace them.
I have left the
MixedDataset
andStrictDataset
alone (apart from small API changes), to ensure that the classes behaviour is not changed.Acceptance Criteria
Test loading a dataset and an image stack
Documentation
Not needed yet