Unify datasets part 2 #2293
Merged
Unify datasets part 2 #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
2199-unify-datasets-2
branch
from
4a975bd to
5f37f16
Compare
Merged
JackEAllen
reviewed
Aug 2, 2024
JackEAllen
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Work on #2199.
Needs rebase after #2288Description
This PR forces named parameters for 'StrictDataset'. That touches many files, so I'll keep it in its own PR.
Testing
Only test changes are to add the parameter names
Acceptance Criteria
Test loading a dataset and an image stack
Documentation
Not needed yet