Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array #118

Merged
merged 8 commits into from
Jun 28, 2024
Merged

Array #118

merged 8 commits into from
Jun 28, 2024

Conversation

JohanMabille
Copy link
Collaborator

Implements #101

Alex-PLACET
Alex-PLACET requested changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@Alex-PLACET Alex-PLACET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed the code which is not in the #117

include/sparrow/array.hpp Outdated Show resolved Hide resolved
include/sparrow/array.hpp Outdated Show resolved Hide resolved
include/sparrow/data_type.hpp Outdated Show resolved Hide resolved
test/test_array.cpp Show resolved Hide resolved
include/sparrow/array.hpp Show resolved Hide resolved
test/test_array.cpp Outdated Show resolved Hide resolved
@JohanMabille JohanMabille force-pushed the array branch 2 times, most recently from e8755ee to b36453c Compare June 26, 2024 12:44
@JohanMabille JohanMabille requested a review from Alex-PLACET June 26, 2024 12:44
@JohanMabille
Copy link
Collaborator Author

oss117-faisonscommeca

@JohanMabille JohanMabille requested a review from Alex-PLACET June 26, 2024 14:04
@JohanMabille JohanMabille force-pushed the array branch 2 times, most recently from c892903 to 305bd77 Compare June 28, 2024 07:18
@JohanMabille JohanMabille marked this pull request as ready for review June 28, 2024 08:07
@JohanMabille JohanMabille merged commit 91b9842 into man-group:main Jun 28, 2024
31 checks passed
@JohanMabille JohanMabille deleted the array branch June 28, 2024 08:44
@JohanMabille JohanMabille mentioned this pull request Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-PLACET Alex-PLACET Alex-PLACET approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohanMabille @Alex-PLACET