Fixed Win tests

man-group · Jun 28, 2024 · 50f65c9 · 50f65c9
1 parent 05d35d2
commit 50f65c9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/include/sparrow/data_traits.hpp b/include/sparrow/data_traits.hpp
@@ -16,6 +16,7 @@
 
 #include "sparrow/data_type.hpp"
 #include "sparrow/fixed_size_layout.hpp"
+#include "sparrow/null_layout.hpp"
 #include "sparrow/variable_size_binary_layout.hpp"
 
 namespace sparrow
@@ -32,9 +33,8 @@ namespace sparrow
     struct arrow_traits<null_type>
     {
         static constexpr data_type type_id = data_type::NA;
-        using value_type = std::nullopt_t;
-        using default_layout = fixed_size_layout<value_type>;  // TODO: replace this by a special layout
-                                                               // that's always empty
+        using value_type = null_type;
+        using default_layout = null_layout;
     };
 
     template <>

diff --git a/test/test_array.cpp b/test/test_array.cpp
@@ -47,15 +47,15 @@ TEST_SUITE("const_array_iterator")
 
     TEST_CASE("default constructor")
     {
-        const_iter_type iter;
+        [[maybe_unused]] const_iter_type iter;
     }
 
     TEST_CASE_TEMPLATE_DEFINE("all", T, all)
     {
         SUBCASE("constructor")
         {
             auto tarray = make_test_typed_array<T>();
-            const_iter_type iter(tarray.cbegin());
+            [[maybe_unused]] const_iter_type iter(tarray.cbegin());
         }
 
         SUBCASE("equality")
@@ -179,7 +179,7 @@ TEST_SUITE("array")
     {
         SUBCASE("constructor")
         {
-            auto ar = make_test_array<T>();
+            [[maybe_unused]] auto ar = make_test_array<T>();
         }
 
         SUBCASE("empty")