-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cgroups v2 pkg #23
Merged
Merged
Commits on Dec 30, 2023
-
* Use containerd cgroups pkg to read cgroups stats * Add slurm_job to metric name to be consistent across collectors * Add cpu and memory PSI metrics * Walk through pids of cgroup only to get job details Signed-off-by: Mahendra Paipuri <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 71d8fce - Browse repository at this point
Copy the full SHA 71d8fceView commit details -
test: Add a new e2e test scenario
* Test when slurm prolog files are not present * This tests if we are able to read procfs correctly and get env vars * Update test fixtures Signed-off-by: Mahendra Paipuri <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a4e9b37 - Browse repository at this point
Copy the full SHA a4e9b37View commit details -
test: Update tests and fixtures
Signed-off-by: Mahendra Paipuri <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 547c85a - Browse repository at this point
Copy the full SHA 547c85aView commit details -
Signed-off-by: Mahendra Paipuri <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f9d8992 - Browse repository at this point
Copy the full SHA f9d8992View commit details
Commits on Jan 1, 2024
-
* Merge GPU jobID map with slurm collector. This is more logical organization instead of having a separate collector * Dont report swap and PSI metrics by default. They can be enabled using CLI flag * Add a hidden flag to force cgroups version for testing * Refacorting of certain receivers to be more clean * Add more unit tests to cover more scenarios * Add test fixtures to be able to unit test * Add more e2e test scenarios Signed-off-by: Mahendra Paipuri <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3cc5c83 - Browse repository at this point
Copy the full SHA 3cc5c83View commit details -
docs: Update README and systemd files
Signed-off-by: Mahendra Paipuri <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 684fa4f - Browse repository at this point
Copy the full SHA 684fa4fView commit details -
chore: Use int indices for devs map
* Iteration over map is undefined in go and not reproducible * To ensure we always have same behaviour we use int as map index and iterate over range * This is done to avoid unit test failures as order in slice gpuOrdinals is important in cmp Signed-off-by: Mahendra Paipuri <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7e5ab16 - Browse repository at this point
Copy the full SHA 7e5ab16View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.