Use cgroups v2 pkg #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mahendrapaipuri
commented
Jan 1, 2024
mahendrapaipuri
commented
- Use containerd's cgroup package to get metrics from v2 as well just like we do for v1
- Merge nVIDIA collector with SLURM collector
- Update tests and add more test scenarios
* Use containerd cgroups pkg to read cgroups stats * Add slurm_job to metric name to be consistent across collectors * Add cpu and memory PSI metrics * Walk through pids of cgroup only to get job details Signed-off-by: Mahendra Paipuri <[email protected]>
* Test when slurm prolog files are not present * This tests if we are able to read procfs correctly and get env vars * Update test fixtures Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
* Merge GPU jobID map with slurm collector. This is more logical organization instead of having a separate collector * Dont report swap and PSI metrics by default. They can be enabled using CLI flag * Add a hidden flag to force cgroups version for testing * Refacorting of certain receivers to be more clean * Add more unit tests to cover more scenarios * Add test fixtures to be able to unit test * Add more e2e test scenarios Signed-off-by: Mahendra Paipuri <[email protected]>
Signed-off-by: Mahendra Paipuri <[email protected]>
* Iteration over map is undefined in go and not reproducible * To ensure we always have same behaviour we use int as map index and iterate over range * This is done to avoid unit test failures as order in slice gpuOrdinals is important in cmp Signed-off-by: Mahendra Paipuri <[email protected]>
mahendrapaipuri
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.