Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sophus: long due update; add tests variant #17581

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

barracuda156
Copy link
Contributor

Description

The port has not been update in 5 years since its introduction: #1360
Update to current version.
Add support for tests. (Not making a default, since building tests is quite demanding in terms of compilation time.)

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 Server
Xcode 3.2.6

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

On PPC there are a few failures with tests: strasdat/Sophus#448

@ex-purple @pmetzger Please review this when you can.

@macportsbot
Copy link

Notifying maintainers:
@ierofant for port Sophus.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port labels Feb 4, 2023
Copy link
Member

@harens harens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @barracuda156. LGTM, but it seems like they've changed the number versioning: strasdat/Sophus@d9610ad

@barracuda156
Copy link
Contributor Author

Thanks @barracuda156. LGTM, but it seems like they've changed the number versioning: strasdat/Sophus@d9610ad

Ok, I will update it today. Thank you.

@barracuda156
Copy link
Contributor Author

@harens Updated to changed versioning.

Copy link
Member

@harens harens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @barracuda156! 👍

@harens harens merged commit 44908f8 into macports:master Feb 7, 2023
@barracuda156 barracuda156 deleted the sophus branch February 8, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.

3 participants