Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace identify method strings with constants #817

Merged
merged 3 commits into from
Dec 20, 2023
Merged

fix: Replace identify method strings with constants #817

merged 3 commits into from
Dec 20, 2023

Conversation

alexs-mparticle
Copy link
Collaborator

@alexs-mparticle alexs-mparticle commented Dec 19, 2023 •
edited
Loading

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Replace Identify method strings with constants
  • Also removes an unused parameter from setForwarderOnUserIdentified

Testing Plan

  • Was this tested locally? If not, explain why.
  • Using a sample app, verify that Identify, Modify, Login and Logout have no changes in behavior.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle mentioned this pull request Dec 19, 2023
Merged
1 task
rmi22186
rmi22186 requested changes Dec 20, 2023
View reviewed changes
Copy link
Member

@rmi22186 rmi22186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments otherwise looks good.

src/forwarders.js Outdated Show resolved Hide resolved
src/identity.js Outdated Show resolved Hide resolved
alexs-mparticle
alexs-mparticle commented Dec 20, 2023
View reviewed changes
src/identity.js Outdated Show resolved Hide resolved
alexs-mparticle
alexs-mparticle commented Dec 20, 2023
View reviewed changes
src/forwarders.js Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexs-mparticle alexs-mparticle merged commit 86dd9f4 into development Dec 20, 2023
26 checks passed
alexs-mparticle added a commit that referenced this pull request Jan 2, 2024
@alexs-mparticle
fix: Replace identify method strings with constants (#817)
1bca974
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
@mparticle-automation
chore(release): 2.23.8 [skip ci]
0d03975 
## [2.23.8](v2.23.7...v2.23.8) (2024-01-02)

### Bug Fixes

* Add filtered user identities to identity complete methods ([#816](#816)) ([715e217](715e217))
* Replace identify method strings with constants ([#817](#817)) ([1bca974](1bca974))
alexs-mparticle pushed a commit that referenced this pull request Jan 2, 2024
@mparticle-automation @alexs-mparticle
chore(release): 2.23.8 [skip ci]
8a67b69 
* Add filtered user identities to identity complete methods ([#816](#816)) ([715e217](715e217))
* Replace identify method strings with constants ([#817](#817)) ([1bca974](1bca974))
alexs-mparticle pushed a commit that referenced this pull request Jan 2, 2024
@mparticle-automation @alexs-mparticle
chore(release): 2.23.8 [skip ci]
3f4f268 
* Add filtered user identities to identity complete methods ([#816](#816)) ([715e217](715e217))
* Replace identify method strings with constants ([#817](#817)) ([1bca974](1bca974))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexs-mparticle @rmi22186