fix: Add filtered user identities to identity complete methods #816

alexs-mparticle · 2023-12-19T21:46:50Z

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Adds filteredUserIdentities parameter to IdentityComplete methods which some kits are expecting

Testing Plan

Was this tested locally? If not, explain why.
Using a sample app with a web kit that uses the web kit wrapper, verify that onIdentifyComplete, onModifyComplete, onLoginComplete and onLogoutComplete pass a second argument within the kit code.
Google Analytics 4 is a kit that expects this second parameter

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-5221
Should be merged after fix: Replace identify method strings with constants #817

rmi22186

Minor comment, otherwise lgtm

src/forwarders.interfaces.ts

sonarqubecloud · 2023-12-20T20:39:24Z

Quality Gate failed

Failed conditions

34.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

## [2.23.8](v2.23.7...v2.23.8) (2024-01-02) ### Bug Fixes * Add filtered user identities to identity complete methods ([#816](#816)) ([715e217](715e217)) * Replace identify method strings with constants ([#817](#817)) ([1bca974](1bca974))

* Add filtered user identities to identity complete methods ([#816](#816)) ([715e217](715e217)) * Replace identify method strings with constants ([#817](#817)) ([1bca974](1bca974))

alexs-mparticle changed the title ~~fix: add filtered user identities to identity complete methods~~ fix: Add filtered user identities to identity complete methods Dec 19, 2023

alexs-mparticle requested a review from rmi22186 December 19, 2023 21:47

rmi22186 requested changes Dec 20, 2023

View reviewed changes

src/forwarders.interfaces.ts Outdated Show resolved Hide resolved

alexs-mparticle commented Dec 20, 2023

View reviewed changes

src/forwarders.interfaces.ts Outdated Show resolved Hide resolved

alexs-mparticle requested a review from rmi22186 December 20, 2023 16:47

rmi22186 approved these changes Dec 20, 2023

View reviewed changes

alexs-mparticle and others added 3 commits December 20, 2023 15:38

fix: add filtered user identities to identity complete methods

52b0b1f

Replace missing types

b3c3bf7

Update src/forwarders.interfaces.ts

f96aa5c

alexs-mparticle force-pushed the fix/SQDSDKS-5221-filteredIdentityRequest branch from f5a5218 to f96aa5c Compare December 20, 2023 20:38

alexs-mparticle merged commit 95a4e8a into development Dec 20, 2023
25 of 26 checks passed

alexs-mparticle added a commit that referenced this pull request Jan 2, 2024

fix: Add filtered user identities to identity complete methods (#816)

715e217

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add filtered user identities to identity complete methods #816

fix: Add filtered user identities to identity complete methods #816

alexs-mparticle commented Dec 19, 2023 •

edited

Loading

rmi22186 left a comment

sonarqubecloud bot commented Dec 20, 2023

fix: Add filtered user identities to identity complete methods #816

fix: Add filtered user identities to identity complete methods #816

Conversation

alexs-mparticle commented Dec 19, 2023 • edited Loading

Instructions

Summary

Testing Plan

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

rmi22186 left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 20, 2023

Quality Gate failed

alexs-mparticle commented Dec 19, 2023 •

edited

Loading