-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update async-profiler to v3.0 #386
Conversation
Happy to merge this, but I think I will wait for v3.1 to drop as there are some commits / bug fixes that have been made since the 3.0 release which I think would be good to have. |
Test buildsThese are using the latest nightly build from async-profiler (currently spark-1.10.113-bukkit.jar.zip Especially interested to hear feedback from anyone using "special" installations, e.g. musl Linux (usually in Alpine docker containers) or OpenJ9 JVMs. |
Tested with Java Oracle GraalVM 23 in a pterodactyl container using Debian 12. No crashes or issues during local testing. Will proceed to upload it to the production server and see what happens. |
The test builds appear to be working as intended for Velocity and a Paper 1.21.1 server with GraalVM Java 23. The servers are running as Pterodactyl servers using images found at https://github.com/ProtobitMC/pterodactyl-graalvm. Thanks for working on a fix! |
Been running this on the production server for a few days now, no issues, would consider stable. |
I tested it with GraalVM23, custom paper fork 1.8.9 and everything works fine. |
In essence, this PR updates
async-profiler
to the recently version 3.0.One main change is that we now don't pull the API from jitpack anymore, but from maven central using the official coordinates (hard to find tbh, but see async-profiler/async-profiler#93 (comment)).
Notable changes:
.so
files, so we don't need to include them manually anymore. However, the path changed, but I guess that's fine.// spark
commentThere are a few things that could be considered following this PR:
-e ctimer
as it doesn't requireperf_events
(Accurate CPU sampling without perf_events async-profiler/async-profiler#855)I tested the changes on linux amd64 and linux arm64.