Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server on Java 23 and above crash with spark enabled #118

Closed
1 task done
NogradThGin opened this issue Sep 19, 2024 · 4 comments
Closed
1 task done

Server on Java 23 and above crash with spark enabled #118

NogradThGin opened this issue Sep 19, 2024 · 4 comments
Labels
bug Something isn't working Not Leaf's fault upstream

Comments

@NogradThGin
Copy link

NogradThGin commented Sep 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What behaviour is observed?

The server crash when using a java version above 22. GraalVM, Azul or classical Java.

Crash occurs when a player join the server with spark background profiler enabled.
You can generate the map with Chunky (did it for 16 mins) as long no player is on the server.

Expected behaviour

No crash when running the server with players.

Actually the argument « -DPurpur.IReallyDontWantSpark=true » doesn't disable Spark.

To Reproduce

Download a 23 or 24 java version.
Start the server.
Join the server.

Plugin list

Spark (enabled)
bStats (disabled)
Chunky
Pl3xmap
Minecraft Prometheus Exporter

Leaf Version

1.21.1

Error log (if applicable)

https://mclo.gs/10IuH0r

Configuration

https://mclo.gs/2oE919l

@NogradThGin NogradThGin added the bug Something isn't working label Sep 19, 2024
@NogradThGin NogradThGin changed the title Java 23 and above crash with spark enabled Server on Java 23 and above crash with spark enabled Sep 19, 2024
@HaHaWTH
Copy link
Member

HaHaWTH commented Sep 19, 2024

Is it reproducible on Purpur?
btw you can disable bundled spark here: https://docs.papermc.io/paper/reference/global-configuration#spark_enabled

@HaHaWTH HaHaWTH added the More information needed Waiting response and provide more information label Sep 19, 2024
@NogradThGin
Copy link
Author

Yes same behavior on Purpur (java 24 GraalVM EA)

@Dreeam-qwq Dreeam-qwq added upstream Not Leaf's fault and removed More information needed Waiting response and provide more information labels Sep 26, 2024
@Dreeam-qwq
Copy link
Member

Dreeam-qwq commented Sep 26, 2024

Spark uses async-profiler for profilering on linux machine. And this crash is a async-profiler issue, referring to related issue async-profiler/async-profiler#923, which is already fixed in async-profiler v3.0+. However, Spark uses async-profiler v2.8.3 for now. There is an existing WIP pr in spark for upgrading async-profiler to 3.0, see lucko/spark#386, but according to lucko's comment, it may not be done very soon.

You can try to disable bundled spark by disabling it in paper config (like @HaHaWTH mentioned above), or switch to Java 21 or 22.

@NogradThGin
Copy link
Author

OK thanks for the update and explanations!
I close the issue as it's not related to Leaf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Not Leaf's fault upstream
Projects
None yet
Development

No branches or pull requests

3 participants