Update KMAC register interfaces #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivos-eblot
reviewed
Dec 17, 2024
This commit updates the KMAC's register interface to match the latest
changes to Earlgrey's KMAC. These changes include:
- Removal of `ERR_PROCESSED` from the `CFG_SHADOWED` register.
- Addition of the `ERR_PROCESSED` command. Most of the functionality
is related to the entropy FSM which is still a TODO, but this does
also clear the relevant alert as in the RTL.
- Replaced `ENTROPY_SEED_{0,4}` with just one `ENTROPY_SEED` register,
which shifts the mappings of subsequent registers.
- Increase the MMIO State and MSG FIFO sizes.
AlexJones0
force-pushed
the
kmac_updates
branch
from
10a919a to
576f055
Compare
rivos-eblot
approved these changes
Dec 17, 2024
loiclefort
reviewed
Dec 17, 2024
loiclefort
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the KMAC's register interface to match the latest changes to Earlgrey's KMAC. These changes include:
ERR_PROCESSEDfrom theCFG_SHADOWEDregister.ERR_PROCESSEDcommand. Most of the functionality is related to the entropy FSM which is still a TODO, but this does also clear the relevant alert as in the RTL.ENTROPY_SEED_{0,4}with just oneENTROPY_SEEDregister, which shifts the mappings of subsequent registers.This change has been tested against previously passing test
kmac_smoketest, which still passes. It also makes the following tests (which were previously failing) pass:kmac_functest,kmac_functest_hardcoded,kmac_mode_cshake_testandkmac_mode_kmac_test. All tests were built from master on OpenTitan.